From:	SMTP%"ewilts@GALAXY.GOV.BC.CA"  7-AUG-1993 11:50:24.36
To:	EVERHART
CC:	
Subj:	Re: Kill filter and NEWS_USAGE_LOG

Message-Id: <9308052245.AA16557@uu7.psi.com>
Date:         Wed, 4 Aug 1993 17:18:24 -0700
Reply-To: Ed Wilts <ewilts@GALAXY.GOV.BC.CA>
Sender: ANU-NEWS Discussion <ANU-NEWS@VM1.NoDak.EDU>
From: Ed Wilts <ewilts@GALAXY.GOV.BC.CA>
Organization: BC Systems Corporation
Subject:      Re: Kill filter and NEWS_USAGE_LOG
To: Multiple recipients of list ANU-NEWS <ANU-NEWS@VM1.NoDak.EDU>

In article <1993Aug4.135800.52325@kuhub.cc.ukans.edu>, sloane@kuhub.cc.ukans.edu
 (Bob Sloane) writes:
> In article <1993Aug4.082630.2900@galaxy.gov.bc.ca>, ewilts@galaxy.gov.bc.ca (E
d Wilts) writes:
>> When using a kill filter, all articles skipped as marked as read.
>> Unfortunately, they are also counted as read articles to NEWS_USAGE_LOG.
>
> This is probably the same problem as articles being reported as read
> when you do a SKIP/FOLLOW on them.
>
>> Is this a known bug?  Is there a known bug list anywhere that is being
>> maintained?  Bob?
>
> This is the first report of this particular bug, although it sounds
> much like the one mentioned above. I don't keep any official list of
> bugs.  I was sort of hoping whoever put the NEWS_USAGE_LOG code in
> NEWS would try to fix the problems with it. Sigh.

I can't remember who the original developer was but I think I've squashed the
bug.  The problem narrowed down to the fact that the log_to_usage_file was
being called in item_update.  I've moved the call to in the do_display routine.

What happens now is that if an already item is read again, it will be counted
again.  On the other hand, an item that isn't being displayed won't be counted.
Also, an item will be counted in the group it is actually read in, not all the
cross-posted groups.  Whether this latter point is better or worse I'm unsure
of.  Comments?

Here's the quicky diffs for NEWSREAD.C and NEWSDISPLAY.C

************
File NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSREAD.C;2
    1   /*Last Modified:  4-AUG-1993 16:52:27 by EWILTS : NEWSREAD.C*/
    2   /*
******
File NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSREAD.C;1
    1   /*
************
************
File NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSREAD.C;2
  101   /*    log_to_usage_file(-1,g); */
  102       if (ga[g]->grp_unread > 0) {
******
File NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSREAD.C;1
  100       log_to_usage_file(-1,g);
  101       if (ga[g]->grp_unread > 0) {
************

Number of difference sections found: 2
Number of difference records found: 2

DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=BCSC$DISK2:[BCSC.MVP.USERS.EWILTS]NEWSREA
D.DIFF;1-
    NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSREAD.C;2-
    NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSREAD.C;1


************
File NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSDISPLAY.C;2
    1   /*Last Modified:  4-AUG-1993 16:53:51 by EWILTS : NEWSDISPLAY.C*/
    2   /*
******
File NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSDISPLAY.C;1
    1   /*
************
************
File NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSDISPLAY.C;2
  739     log_to_usage_file(-1,curr_g);         /* EWILTS */
  740     if (!tpucall) {
******
File NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSDISPLAY.C;1
  738     if (!tpucall) {
************

Number of difference sections found: 2
Number of difference records found: 2

DIFFERENCES /IGNORE=()/MERGED=1/OUTPUT=BCSC$DISK2:[BCSC.MVP.USERS.EWILTS]NEWSDIS
PLAY.DIFF;1-
    NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSDISPLAY.C;2-
    NEWS_MANAGER_DEV:[SOURCE.NEWS61B7.NEWS_SRC]NEWSDISPLAY.C;1

--
Ed Wilts, BC Systems, 4000 Seymour Place, Victoria, B.C., Canada, V8X 4S8
EWilts@Galaxy.Gov.BC.CA     Office:  (604) 389-3430   Fax: (604) 389-3412
